Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebAuth Issue #19

Closed
christian-rogobete opened this issue Dec 15, 2022 · 1 comment
Closed

WebAuth Issue #19

christian-rogobete opened this issue Dec 15, 2022 · 1 comment

Comments

@christian-rogobete
Copy link
Contributor

Hello some Payment System recommended yor sdk for integration.
and i found error in ur method https://github.com/Soneso/stellar-php-sdk/blob/main/Soneso/StellarSDK/SEP/WebAuth/WebAuth.php
signTransaction

$signatures = array();
array_push($signatures, $envelopeXdr->getV1()->getSignatures());

we should use just
$signatures = $envelopeXdr->getV1()->getSignatures();

cuz getSignatures return array
if we use 1st variant we have incorrect subscribe transaction becos fw have wrong signature array like
[[sigen1], sign2]
when it should be
[sign1, sign2]

christian-rogobete added a commit that referenced this issue Dec 15, 2022
@christian-rogobete
Copy link
Contributor Author

fixed in release 1.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant