Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Cache Username + [Refactor] #2

Merged
merged 1 commit into from Aug 5, 2017
Merged

[Feature] Cache Username + [Refactor] #2

merged 1 commit into from Aug 5, 2017

Conversation

ApolloZhu
Copy link
Contributor

@ApolloZhu ApolloZhu commented Aug 5, 2017 •
edited

  • Less Objective-C like code
  • Immutable struct for commit data
  • Factor out redundant code (Alerts, date formatters)
    • (hopefully, correctly) Merged two loops into one (for positioning SCNBoxes)

@ApolloZhu
[Feature] Cache Username + [Refactor]
6d6609a 
- Less Objective-C like code
- Immutable struct for commit data
- Factor out redundant code (Alerts, date formatters)
  + Merged two loops into one (for positioning SCNBoxes)
@krayc425 krayc425 merged commit 219c869 into krayc425:master Aug 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ApolloZhu @krayc425