Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add to switcher the 管理插件的插件 #36

Closed
suntong opened this issue Nov 25, 2017 · 7 comments
Closed

add to switcher the 管理插件的插件 #36

suntong opened this issue Nov 25, 2017 · 7 comments

Comments

@suntong
Copy link

suntong commented Nov 25, 2017

Hi @songtianyi,

The new plugin that I'm writting (#34) need more functionalities to switcher the 管理插件的插件. So far it supports:

#关闭某个插件, 在微信聊天窗口输入
disable faceplusplus
#开启某个插件, 在微信聊天窗口输入
enable faceplusplus
#查看所有插件信息, 在微信聊天窗口输入
dump

Please (consider) adding one more command to it,

config [plugin] more config strings for the plugin

and have a way for the plugin to take the more config strings for the plugin and do its own configuration.

I need to pass two integers to my plugin for its configuration, which I can take care of it myself when I get the string.

Thanks for consideration!

@songtianyi
Copy link
Owner

songtianyi commented Nov 25, 2017

session.HandlerRegister.GetByName(string).SetConfig(string,  interface{})
session.HandlerRegister.GetByName(string).GetConfig(string) interface{}

It's that ok for you?

@songtianyi
Copy link
Owner

songtianyi commented Nov 25, 2017

I prefer to add a local(or remote) memory config store module to manage user configurations, and add a new plugin to do getter or setter things.

@suntong
Copy link
Author

suntong commented Nov 25, 2017

I trust you'd make the best decision, so whatever you decide and implement, I'll use it.

Thanks for doing that.

@songtianyi
Copy link
Owner

Sorry, i'll implement the feature this weekend.

@suntong
Copy link
Author

suntong commented Nov 29, 2017

NP. Take your time.

Your first proposal is more aiming towards back-end configurations, and I'm glad that you've also planned for the user front-end configurations. 👍

@songtianyi
Copy link
Owner

songtianyi commented Dec 3, 2017

Done. Please check the updated source code and README for usages.

@suntong
Copy link
Author

suntong commented Dec 5, 2017

Cool!

I'll take a look this weekend -- I was recovering from the jet-lag after a short trip to China...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants