You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
In the advance-reboot, after the test pass, it will verify some log information from the syslog in post_reboot_analysis, but sometimes, the functional of the test does not have any issue, but failed when check the information from the syslog due to such as the log rate limt or the log supress in the SONiC. need to use a much more reliable method replace this part of checking
For example:
Event LAG_READY was found 0 times, when expected exactly 9 times
def verify_required_events(duthost, event_counters, timing_data, verification_errors):
for key in ["time_span", "offset_from_kexec"]:
for pattern in REQUIRED_PATTERNS.get(key):
if pattern == 'PORT_READY':
observed_start_count = timing_data.get(
key, {}).get(pattern, {}).get("Start-changes-only count", 0)
else:
observed_start_count = timing_data.get(
key, {}).get(pattern, {}).get("Start count", 0)
observed_end_count = timing_data.get(
key, {}).get(pattern, {}).get("End count", 0)
expected_count = event_counters.get(pattern)
# If we're checking PORT_READY, and there are 0 port state change messages captured instead of however many
# was expected, treat it as a success. Some platforms (Mellanox, Dell S6100) have 0, some platforms (Arista
# 050cx3) have however many ports are up.
if observed_start_count != expected_count and (pattern != 'PORT_READY' or observed_start_count != 0):
verification_errors.append("FAIL: Event {} was found {} times, when expected exactly {} times".
format(pattern, observed_start_count, expected_count))
if key == "time_span" and observed_start_count != observed_end_count:
verification_errors.append("FAIL: Event {} counters did not match. ".format(pattern) +
"Started {} times, and ended {} times".
format(observed_start_count, observed_end_count))
Steps to reproduce the issue:
run the advance-reboot
Describe the results you received:
Failed: Advanced-reboot failure. Failed test: test_fast_reboot[], failure summary:
[('test_fast_reboot[]None', ['FAIL: Event LAG_READY was found 0 times, when expected exactly 9 times'])]
Describe the results you expected:
need to use a much more reliable method replace this existing part of checking information from syslog.
Additional information you deem important:
**Output of `show version`:**
```
(paste your output here)
```
**Attach debug file `sudo generate_dump`:**
```
(paste your output here)
```
The text was updated successfully, but these errors were encountered:
Description
In the advance-reboot, after the test pass, it will verify some log information from the syslog in post_reboot_analysis, but sometimes, the functional of the test does not have any issue, but failed when check the information from the syslog due to such as the log rate limt or the log supress in the SONiC. need to use a much more reliable method replace this part of checking
For example:
Event LAG_READY was found 0 times, when expected exactly 9 times
Steps to reproduce the issue:
Describe the results you received:
Failed: Advanced-reboot failure. Failed test: test_fast_reboot[], failure summary:
[('test_fast_reboot[]None', ['FAIL: Event LAG_READY was found 0 times, when expected exactly 9 times'])]
Describe the results you expected:
need to use a much more reliable method replace this existing part of checking information from syslog.
Additional information you deem important:
The text was updated successfully, but these errors were encountered: