Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

library: Adds Adw.AboutWindow entry #305

Merged
merged 5 commits into from Jun 13, 2023

Conversation

SoNiC-HeRE
Copy link
Contributor

Closes #283

@SoNiC-HeRE
Copy link
Contributor Author

Changed the design and code to implement something similar to :
Was'nt sure about the credit section so thought of adding mine

image

@sonnyp sonnyp requested review from sonnyp and removed request for andyholmes June 11, 2023 08:37
@SoNiC-HeRE SoNiC-HeRE changed the title Adds Adw.AboutWindow Demo library: Adds Adw.AboutWindow entry Jun 11, 2023
Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, nice and simple.

One thing worth demoing is Adw.AboutWindow.add_acknowledgement_section(), since that gets used for donation pages. Then LGTM!

Copy link
Contributor

@andyholmes andyholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@andyholmes andyholmes merged commit 960276f into workbenchdev:main Jun 13, 2023
sonnyp pushed a commit that referenced this pull request Jun 17, 2023
* Adds Adw.AboutWindow Demo
* Updated Link
* Updated Code
* Updated Icon
* Added Acknowledgement Section
sonnyp pushed a commit that referenced this pull request Jun 20, 2023
* Adds Adw.AboutWindow Demo
* Updated Link
* Updated Code
* Updated Icon
* Added Acknowledgement Section
sonnyp pushed a commit to SoNiC-HeRE/Workbench that referenced this pull request Aug 13, 2023
* Adds Adw.AboutWindow Demo
* Updated Link
* Updated Code
* Updated Icon
* Added Acknowledgement Section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AboutWindow library entry
2 participants