New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
library: Add location entry #355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Library/demos/Location/main.blp
Outdated
adjustment: Adjustment { | ||
lower: 0; | ||
upper: 100; | ||
step-increment: 1; | ||
value: 0; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only 2 spaces indent please, example:
adjustment: Adjustment { | |
lower: 0; | |
upper: 100; | |
step-increment: 1; | |
value: 0; | |
}; | |
adjustment: Adjustment { | |
lower: 0; | |
.. | |
}; |
src/Library/demos/Location/main.blp
Outdated
} | ||
} | ||
|
||
Adw.ActionRow { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use a Adw ComboRow instead of an ActionRow
+ DropDown
I've applied all the mentioned changes and it seems to work fine and does'nt break even when a session has started and i press run button again; maybe can you try again and lemme know if that happens again? |
It happens when the session isn't closed before pressing "Run" again. I'm not sure what we can do about it at the moment. Possibly we have to wait until we support opening JS demo in a separate process. I'll investigate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this, I have filed an issue about the problem which we can tackle later
Closes #350
Implemented the following changes:
Looking for an early review