library: Adds columnview entry #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've implemented the following:
P.S:
What else can be demonstrated here? @andyholmes |
andyholmes
requested changes
Jul 22, 2023
andyholmes
requested changes
Aug 3, 2023
There was a problem hiding this comment.
Cool, once the date column is reporting a basic date, it's on to the "fun" part: column sorting.
Do you want to work through column sorting together, or if I link you to Gtk.ColumnView.get_sorter() as a hint do you can get the name column sorting?
| factory.connect("bind", (factory, list_item) => { | ||
| const label_widget = list_item.get_child(); | ||
| const model_item = list_item.get_item(); | ||
| label_widget.label = model_item.get_size().toString(); |
There was a problem hiding this comment.
Probably we want to use a human readable size here, but let's leave that for the polish phase.
There was a problem hiding this comment.
Be sure to double-check my math, but this should be good enough:
if (Math.floor(size / 1_000_000_000) > 0)
label_widget.label = `${(size / 1_000_000_000).toFixed(1)} GB`
else if (Math.floor(size / 1_000_000) > 0)
label_widget.label = `${(size / 1_000_000).toFixed(1)} MB`
else if (Math.floor(size / 1000) > 0)
label_widget.label = `${(size / 1000).toFixed(1)} kB`
else
label_widget.label = `${(size / 1000)} bytes`
andyholmes
requested changes
Aug 6, 2023
| factory.connect("bind", (factory, list_item) => { | ||
| const label_widget = list_item.get_child(); | ||
| const model_item = list_item.get_item(); | ||
| label_widget.label = model_item.get_size().toString(); |
There was a problem hiding this comment.
Be sure to double-check my math, but this should be good enough:
if (Math.floor(size / 1_000_000_000) > 0)
label_widget.label = `${(size / 1_000_000_000).toFixed(1)} GB`
else if (Math.floor(size / 1_000_000) > 0)
label_widget.label = `${(size / 1_000_000).toFixed(1)} MB`
else if (Math.floor(size / 1000) > 0)
label_widget.label = `${(size / 1000).toFixed(1)} kB`
else
label_widget.label = `${(size / 1000)} bytes`
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
* Add columnview * test * Update * Clean Up and implement colview * Refactoring and applied suggested changes * Applied changes * Progress * Updated * Update * Update * Reverse * Applied Suggested Changes * Minor Change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.