Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Adw.MessageDialog.choose() #512

Merged
merged 7 commits into from Aug 20, 2023
Merged

Use Adw.MessageDialog.choose() #512

merged 7 commits into from Aug 20, 2023

Conversation

SoNiC-HeRE
Copy link
Contributor

Close #465

@SoNiC-HeRE SoNiC-HeRE marked this pull request as draft August 20, 2023 11:56
@SoNiC-HeRE SoNiC-HeRE changed the title update: Adw.MessageDialog.choose() update: all usecases of Adw.MessageDialog to Adw.MessageDialog.choose() Aug 20, 2023
@sonnyp
Copy link
Contributor

sonnyp commented Aug 20, 2023

Don't forget to replace

  const response = await new Promise((resolve) => {
    dialog.connect("response", (self, response) => resolve(response));
  });

in window.js - you'll need the promisify in init.js as well

@sonnyp sonnyp changed the title update: all usecases of Adw.MessageDialog to Adw.MessageDialog.choose() Use Adw.MessageDialog.choose() Aug 20, 2023
@SoNiC-HeRE SoNiC-HeRE marked this pull request as ready for review August 20, 2023 13:46
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100/100

@sonnyp sonnyp merged commit 2fc619f into main Aug 20, 2023
@sonnyp sonnyp deleted the sonic/messagedialog branch August 20, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Adw.MessageDialog.Choose
2 participants