Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to sign when there is any non .mobileprovision file in Profiles folder #77

Closed
vhnatyk opened this issue Feb 11, 2019 · 3 comments
Closed

Comments

@vhnatyk
Copy link

vhnatyk commented Feb 11, 2019

Hi! I'm blessed to find this amazing tool folks and I can't tell how thankful I am:)!

However, there is an issue that puzzled me for a day to the point I almost gave up. If there is any file (that is not provision profile) or folder with update date higher then our Dinghy provisioning profile, then it fails with not too descriptive Rust error "failed to fill whole buffer".

So for example if you view the folder with Finder (like we - guys coming from Windows - usually do with visual tools and not cmd :D ), then .DS_Store file is always updated or if you happen to create some folder to backup some profiles - anything that is not signing profile with higher date will cause Dinghy to read it first and exit with the confusing error message.

I will try to do the PR for the fix - it's in xcode.rs:124, but if you'd be faster to fix, I won't be jealous I promise since I'm pretty new to Rust.

Again many thanx for the great tool.

You guys rock!

@kali
Copy link
Collaborator

kali commented Feb 12, 2019

Thanks for the report and the kind words !

As you can see, the fix is hopefully on its way, I will cut a new version right away.

@kali
Copy link
Collaborator

kali commented Feb 13, 2019

Hey, could you confirm the latest release fix your issue ?

@vhnatyk
Copy link
Author

vhnatyk commented Feb 21, 2019

Hi - sorry for delay. Issue is fixed, but there is another related one regarding auto-signing profiles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants