Add motor command to sonrd with login/register subcommands #536
Conversation
Codecov ReportBase: 5.91% // Head: 5.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #536 +/- ##
========================================
- Coverage 5.91% 5.91% -0.01%
========================================
Files 115 115
Lines 14512 14520 +8
========================================
Hits 859 859
- Misses 13578 13586 +8
Partials 75 75
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
added @SCKelemen |
|
|
||
| // Arch returns the current architecture. | ||
| func Arch() string { | ||
| return runtime.GOARCH |
|
|
||
| const K_SERVICE_NAME = "sonr-dev" | ||
|
|
||
| type UserAuth struct { |
There was a problem hiding this comment.
Is this the struct representing the authorization form, or are we also storing this struct?
| if i.AesDSCKey == nil { | ||
| return false | ||
| } | ||
| if len(i.AesDSCKey) < 32 { |
There was a problem hiding this comment.
This is weird.
AES Keys can only be 128, 192, or 256 bits, meaning this key has to be 32 bytes or 256 bits. Therefore, should this check not be strict equality?
| func (i UserAuth) GenAccountCreateRequest() (*mt.CreateAccountRequest, error) { | ||
| if i.Validate() { | ||
| return &mt.CreateAccountRequest{ | ||
| Password: i.Password, |
There was a problem hiding this comment.
Assuming here this is the password in flight. Please let me know if this assumption is incorrect.
There was a problem hiding this comment.
sent across the wire for authentication purposes, ie a web login form
|
Are we still planning on doing this? |
Same method with same structure should be in speedway. @ntindle This doesnt use binding layer. |
|
Closing this PR for now for inactivity. |
See demo. Initial setup of motor command to create/login a Sonr account pulled from speedway and enhanced with Keychain, table logging.
API Updates
New Features (required)
sonrd motor registerChecklist
Fixes
Connects