Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduction to number of device shards generated. #687

Merged
merged 1 commit into from Oct 14, 2022

Conversation

joshLong145
Copy link

@joshLong145 joshLong145 commented Oct 11, 2022

  • reduces device shards down to three

Changes

  • Item 1
  • Item 2

API Updates

New Features (required)

Deprecations (required)

Enhancements (optional)

Checklist

  • Unit tests
  • Documentation

References (optional)

Fixes
Connects

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

Copy link

@mcjcloud mcjcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 5.25% // Head: 5.65% // Increases project coverage by +0.39% 🎉

Coverage data is based on head (ac0ba4e) compared to base (7ca25b9).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #687      +/-   ##
========================================
+ Coverage   5.25%   5.65%   +0.39%     
========================================
  Files        143     143              
  Lines      26922   26922              
========================================
+ Hits        1415    1522     +107     
+ Misses     25366   25231     -135     
- Partials     141     169      +28     
Impacted Files Coverage Δ
pkg/crypto/mpc/config.go 41.86% <ø> (ø)
pkg/crypto/mpc/cmp.go 11.47% <0.00%> (+3.27%) ⬆️
pkg/crypto/mpc/wallet.go 12.43% <0.00%> (+5.47%) ⬆️
pkg/crypto/mpc/network.go 88.33% <0.00%> (+26.66%) ⬆️
pkg/motor/create_account.go 41.83% <0.00%> (+30.71%) ⬆️
pkg/motor/create_bucket.go 50.00% <0.00%> (+50.00%) ⬆️
pkg/motor/ssi.go 52.63% <0.00%> (+52.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ntindle
Copy link

ntindle commented Oct 13, 2022

Is there anywhere that checks this or requires x number of shards on the vault side? @mcjcloud

@ntindle
Copy link

ntindle commented Oct 13, 2022

Have we benchmarked this? May be worth pushing into calhard

@joshLong145
Copy link
Author

Is there anywhere that checks this or requires x number of shards on the vault side? @mcjcloud

the checks are on if there are device shards left not any specific amount.

@joshLong145 joshLong145 merged commit 64ffc2e into dev Oct 14, 2022
@joshLong145 joshLong145 deleted the update/device-shards-wallet branch October 14, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants