Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creation of test suite for pkg/ipns #710

Merged
merged 2 commits into from Oct 20, 2022
Merged

creation of test suite for pkg/ipns #710

merged 2 commits into from Oct 20, 2022

Conversation

joshLong145
Copy link

@joshLong145 joshLong145 commented Oct 18, 2022

  • removes test case from ipns that would always fail due to the given cid not being present.

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@ntindle
Copy link

ntindle commented Oct 18, 2022

Should this just upload something in a setup?

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

Base: 5.69% // Head: 5.58% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (f1fed5a) compared to base (a0d335b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #710      +/-   ##
========================================
- Coverage   5.69%   5.58%   -0.12%     
========================================
  Files        150     154       +4     
  Lines      27919   27979      +60     
========================================
- Hits        1591    1562      -29     
- Misses     26157   26248      +91     
+ Partials     171     169       -2     
Impacted Files Coverage Δ
pkg/crypto/mpc/network.go 61.66% <0.00%> (-26.67%) ⬇️
pkg/crypto/mpc/wallet.go 6.96% <0.00%> (-5.48%) ⬇️
pkg/crypto/mpc/cmp.go 8.19% <0.00%> (-3.28%) ⬇️
pkg/ipns/crypto.go 0.00% <0.00%> (ø)
pkg/ipns/record.go 0.00% <0.00%> (ø)
pkg/ipns/ipns.go 0.00% <0.00%> (ø)
pkg/ipns/builder.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@joshLong145 joshLong145 changed the title removal of stale test case creation of test suite for pkg/ipns Oct 19, 2022
@joshLong145
Copy link
Author

Should this just upload something in a setup?

Added it to a suite so an document is created and uploaded with a cid

@ntindle
Copy link

ntindle commented Oct 19, 2022

Closes #648

@ntindle ntindle linked an issue Oct 19, 2022 that may be closed by this pull request
@mcjcloud mcjcloud merged commit 6abf4b9 into dev Oct 20, 2022
@mcjcloud mcjcloud deleted the remove/ipns-test branch October 20, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pkg/ipns tests and make them CI Run-able
4 participants