New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLOK-25: Move vault creation to go routine #716
Conversation
BLOK-25 Trigger Vault processes with coroutine and callback
In order to speed up account creation and login, return from the function as soon as transaction signing is possible. Provide callbacks for vault creation. |
Codecov ReportBase: 5.79% // Head: 5.15% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #716 +/- ##
========================================
- Coverage 5.79% 5.15% -0.65%
========================================
Files 165 128 -37
Lines 28404 25923 -2481
========================================
- Hits 1647 1336 -311
+ Misses 26591 24464 -2127
+ Partials 166 123 -43 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This would be massive 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG I don't know why the builds for ignite are failing but they should have no implication on the blockchain
I think the ignite installer is hitting its own rate limit |
Moves vault creation into a go routine to speed up account creation.
Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.