Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOK-25: Move vault creation to go routine #716

Merged
merged 3 commits into from Oct 24, 2022
Merged

BLOK-25: Move vault creation to go routine #716

merged 3 commits into from Oct 24, 2022

Conversation

mcjcloud
Copy link

@mcjcloud mcjcloud commented Oct 22, 2022

Moves vault creation into a go routine to speed up account creation.

 Mention [stepsize] in a comment if you'd like to report some technical debt. See examples here.

@linear
Copy link

linear bot commented Oct 22, 2022

BLOK-25 Trigger Vault processes with coroutine and callback

In order to speed up account creation and login, return from the function as soon as transaction signing is possible. Provide callbacks for vault creation.

@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2022

Codecov Report

Base: 5.79% // Head: 5.15% // Decreases project coverage by -0.64% ⚠️

Coverage data is based on head (f54fea6) compared to base (22be89d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #716      +/-   ##
========================================
- Coverage   5.79%   5.15%   -0.65%     
========================================
  Files        165     128      -37     
  Lines      28404   25923    -2481     
========================================
- Hits        1647    1336     -311     
+ Misses     26591   24464    -2127     
+ Partials     166     123      -43     
Impacted Files Coverage Δ
x/schema/types/what_is.pb.go 0.74% <ø> (ø)
pkg/motor/create_account.go
pkg/host/config.go
pkg/crypto/jwt/jwt.go
pkg/motor/send_tokens.go
pkg/client/service.go
pkg/client/query.go
pkg/ipns/crypto.go
pkg/crypto/jwt/config.go
pkg/host/state_machine.go
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BBBmau
Copy link

BBBmau commented Oct 22, 2022

This would be massive 🙏

@prnk28 prnk28 self-requested a review October 22, 2022 06:17
Copy link
Contributor

@prnk28 prnk28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG I don't know why the builds for ignite are failing but they should have no implication on the blockchain

@ntindle
Copy link

ntindle commented Oct 22, 2022

I think the ignite installer is hitting its own rate limit

@mcjcloud mcjcloud merged commit 90913e4 into dev Oct 24, 2022
@mcjcloud mcjcloud deleted the brayden/blok-25 branch October 24, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants