Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/crypto deps #832

Merged
merged 12 commits into from
Dec 16, 2023
Merged

Fix/crypto deps #832

merged 12 commits into from
Dec 16, 2023

Conversation

prnk28
Copy link
Contributor

@prnk28 prnk28 commented Dec 16, 2023

No description provided.

@prnk28
Upgrade dependency versions and remove exclusions
60cd87d 
Updated various dependencies to newer versions, improving compatibility
and stability. Removed unnecessary exclusions from
`.vscode/settings.json`. Refactored crypto codebase with the updated
`github.com/btcsuite/btcd/btcec/v2` package and its new import paths,
ensuring cryptographic functionalities are up-to-date. Adjusted
`ec_point_test.go` and other test files to align with these changes.
Deleted obsolete benchmark test file `benches_test.go` from
`crypto/tecdsa/gg20/participant`, streamlining the test suite.
@prnk28
Refactor release process, streamline CI/CD flow
d52db55 
Removed the 'run-goreleaser' step from the GitHub Actions release
workflow and integrated publishing functionality directly into the
Taskfile. The CI/CD pipeline now utilizes 'task publish' for building
and pushing service images, which simplifies the process and leverages
earthly commands for consistency across all build and publish stages.
This change aims to streamline the release process by consolidating
build commands under a single task management tool, reducing potential
errors and improving maintainability.
@naming-conventions-bot Naming Conventions Bot
Copy link

Please follow naming conventions! 😿

@watermelon-copilot-for-code-review Watermelon - Copilot For Code Review
Copy link

watermelon-copilot-for-code-review bot commented Dec 16, 2023 •
edited
Loading

Watermelon AI Summary

This Pull Request implements several refinements to the project, focusing on upgrading cryptography dependencies for enhanced security, streamlining the release process and CI/CD pipeline for efficiency, optimizing repository setup for build consistency and performance, along with various fixes to maintain cleanliness and effectiveness of workflows and testing protocols.

GitHub PRs

sonr is an open repo and Watermelon will serve it for free.
🍉🫶
Why not invite more people to your team?

@what-the-diff What The Diff
Copy link

what-the-diff bot commented Dec 16, 2023

PR Summary

  • Updated References to External Library (btcec)
    Numerous files across the project have been updated to refer to the newer version (v2) of the external library btcec. This library plays a crucial role in cryptographic operations in the project. The update is important for keeping the project up-to-date with latest security standards and improvements offered by btcec.

  • Optimized Workflow for Release and Publishing
    The workflow file that controls how the software is built, packaged, and published for release had some steps removed and a new step involving the task publish command added. This should streamline and optimize the release process.

  • Updated Developer Workspace Settings
    Some entries were removed from the .vscode/settings.json file. It keeps a record of custom settings that apply when working in the VS Code editor. The removal of these entries suggests some tidying up of unnecessary or outdated settings.

  • Modification of essential Taskfile
    A new action was added to the project's Taskfile.yml. This file describes a series of "tasks" or actions that can be executed using the command line. The addition of the new task enhances the range of operations that can be easily executed by developers.

  • Version Upgrade for btcd Dependency
    The version of the btcd dependency in the go.mod file was updated to its latest version. This ensures that the project benefits from the most recent updates, features, and security improvements of that library.

  • Other File Mode Changes
    The permissions for two files, namely rounds_test.go and go.mod, have been slightly altered. The change shouldn't directly impact end users but it does affect how developers interact with these files.

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Dec 16, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

@prnk28
Optimize repo setup and test workflows
b313622 
Refactored Earthfile and Taskfile.yml to streamline the repository setup
process by cloning only the necessary repository with a specific branch
argument, enhancing caching strategies for dependencies and reducing
redundancy. Updated testing task to utilize the new repository setup and
standardized external repository references across all build and publish
commands. Additionally, updated go.work.sum to include new module
version hashes, ensuring dependency tracking is up-to-date.

Resolves #123, where build consistency and performance were major
concerns.
@prnk28
Add local source copy step to test Earthfile
3fffba3 
target

Enabled the copying of the local source code into the test environment
when running tests. This ensures that the latest codebase is used during
the testing phase, reflecting more accurate and up-to-date test results.
@prnk28
fix: simplify newpr workflow
8c896cb
@prnk28
fix: lint protos
aacb0e3
@prnk28
Merge branch 'main' into fix/crypto-deps
6ddf531 
Signed-off-by: Prad Nukala <prad@sonr.io>
@prnk28
fix: remove root monorepo test
2b7d07c
@prnk28
fix: validate protos
2abfefb
@prnk28
fix: downgrade pr labeler
1d097e6
@prnk28 prnk28 merged commit 66d03b7 into main Dec 16, 2023
8 of 10 checks passed
@prnk28 prnk28 deleted the fix/crypto-deps branch December 16, 2023 04:42
This was referenced Dec 16, 2023
Merged
Closed
Merged
@prnk28 prnk28 added this to the Public Testnet Deployment milestone Feb 2, 2024
@watermelon-copilot-for-code-review watermelon-copilot-for-code-review bot mentioned this pull request Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@prnk28