Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 5 / Xcode 11 support [WIP] #223

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

jakunico
Copy link

@jakunico jakunico commented Mar 7, 2020

I had an old project that depended on reddift - I'm trying to resurrect that project and reddift was not working with swift 5 and Xcode 11. This PR should hopefully fix that.

image

App, frameworks and tests compile with no warnings:

image

I've faced a couple of challenges with tests:

  1. Some tests are failing to me, from what I saw some of them depend on your reddit user, for instance UsersTest.testGetUserContents uses sonson_twit username which obviously does not match mine (see image below).
  2. Travis needs to read some encrypted variables which are not available when you are a contributor (as you would be able to edit the travis script and print out those). Maybe you can merge temporarily into a swift-5 branch instead of master and then run tests on travis by opening a swift-5 > master PR.

image

@jakunico jakunico changed the title Swift 5 / Xcode 11 support Swift 5 / Xcode 11 support [WIP] Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant