Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Pyramid 1.10 due to removal of set_request_property #65

Closed
Deimos opened this issue Nov 1, 2018 · 4 comments
Closed

Comments

@Deimos
Copy link
Contributor

Deimos commented Nov 1, 2018

Pyramid 1.10 has removed the pyramid.config.Configurator.set_request_property method (which has been deprecated since 1.5): https://docs.pylonsproject.org/projects/pyramid/en/latest/whatsnew-1.10.html#backward-incompatibilities

pyramid_webassets uses this, so it currently crashes when used with Pyramid 1.10:

config.set_request_property(get_webassets_env_from_request,
'webassets_env', reify=True)
config.set_request_property(assets, 'webassets', reify=True)

@tilgovi
Copy link
Collaborator

tilgovi commented Nov 2, 2018

Would you make a PR replacing it with add_request_method, please? We can then make sure all the tests pass and release a 0.10 version.

@tilgovi
Copy link
Collaborator

tilgovi commented Nov 2, 2018

Also, please bump the Pyramid requirement in setup.py to pyramid >= 1.4.

@Deimos
Copy link
Contributor Author

Deimos commented Nov 2, 2018

Sure, I can do the PR if someone can do a release for it. Thanks.

@tilgovi
Copy link
Collaborator

tilgovi commented Nov 3, 2018

Closed by #66 and released as v0.10. Thanks, @Deimos!

@tilgovi tilgovi closed this as completed Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants