Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OrthogonalInitializer #265

Closed

Conversation

takuseno
Copy link
Contributor

Hi, @TE-TakuyaNarihira san, @TE-AkioHayakawa san!
#243 takes a bit time because my school started 😢

Anyway, I implemented OrthogonalInitializer which is widely available on other DNN libraries but still effective way in many domains.

If you think it might be good to nnabla, I will test this more to remove WIP sign.

Thank you!

@takuseno
Copy link
Contributor Author

PS. Are there C++ initialization codes? I could not find any files related to weight initialization.

@TakuyaNarihira
Copy link
Contributor

TakuyaNarihira commented Oct 19, 2018

Thanks for the PR.

PS. Are there C++ initialization codes? I could not find any files related to weight initialization.

No C++ initialization so far. All weight initialization is performed in Python-side.

@TakuyaNarihira
Copy link
Contributor

@takuseno I'll review soon.

@TakuyaNarihira
Copy link
Contributor

It must be useful for many people, and the code logic looks good to me. Thanks for your PR. Could you add unit tests for this feature? See the unit testing script for initializers which we just added at #270 for this PR :).

@takuseno
Copy link
Contributor Author

@TE-TakuyaNarihira Thank you! I'll handle that!

@takuseno takuseno changed the title [WIP] Implement OrthogonalInitializer Implement OrthogonalInitializer Dec 26, 2018
@takuseno
Copy link
Contributor Author

@TE-TakuyaNarihira
I've added the unit test!! It is based on PyTorch implementation. And, the test has passed on my machine.

@takuseno takuseno force-pushed the implement_orthogonal_initializer branch from 474a898 to 07fea2a Compare February 28, 2019 14:58
@takuseno
Copy link
Contributor Author

@TE-KazukiYoshiyama san. I set a default rng with RandomState(313), and I confirmed that my unit test has passed.

@TakuyaNarihira TakuyaNarihira added the release-note-utility Auto-release; Utilities label Apr 3, 2019
@AkioHayakawa-sony
Copy link
Member

This PR is moved to #547 and will be merged to master.

MasatoIshii-sony pushed a commit that referenced this pull request Nov 24, 2021
TE-StephenTiedemann pushed a commit that referenced this pull request Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-utility Auto-release; Utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants