Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disc number column emptied after play #41

Closed
Forage opened this issue Aug 26, 2021 · 6 comments
Closed

Disc number column emptied after play #41

Forage opened this issue Aug 26, 2021 · 6 comments

Comments

@Forage
Copy link

Forage commented Aug 26, 2021

Hi,

I found a minor issue in 1.3.0.

When starting to play an album the Disc column is filled for all the tracks. However, after a track has finished playing the disc column value of that track is emptied and remains empty.

Screenshot from 2021-08-26 14-49-50

It does not happen when you jump to the next from one that is playing.

Tested with just MP3 files and running mpdevil on Ubuntu 21.04 with MPD 0.22.9.
Let me know if you need a test file or if you're already able to reproduce it with your own.

@SoongNoonien
Copy link
Owner

Sorry, I'm not able to reproduce it here. It works perfectly fine. When you start mpdevil with -d is there anything printed on the console when the number vanishes except from the periodical status and some currentsong calls? Do the numbers reappear when you restart mpdevil?

@Forage
Copy link
Author

Forage commented Aug 26, 2021

The log gives me nothing out of the ordinary, unless it's the plchanges
Screenshot from 2021-08-26 16-28-13
A restart of mpdevil does not fix it, only switching between albums.

@SoongNoonien
Copy link
Owner

The log gives me nothing out of the ordinary, unless it's the plchanges

plchanges get run if and only if mpd reports a new playlist version. Something seems to make mpd change the playlist version all of a sudden.

A restart of mpdevil does not fix it, ...

This sounds like the bug is on mpd's side. Do other clients with a similar playlist view (e.g. Cantata) display the disc's correctly?
If possible please send me the output of this script (zipped archive) when the playlist is "corrupted". It will simply fetch the metadata of the whole playlist via python-mpd2 (the client library I'm using). This will help to determine if the disc tag gets transmitted correctly. If your server listens on a none standard port or is even on another host than the client you may have to change the credentials in line 4.

... only switching between albums.

What do you mean by that? Clearing the playlist and playing another album?

@Forage
Copy link
Author

Forage commented Aug 26, 2021

Using MALP to show the track details gives me a 0 for the disc number after a track has been played. It also appear to do a quick screen flash as if refreshing the whole playlist.

{'file': 'Dido/No Angel/disc 1/01. Here With Me.mp3', 'last-modified': '2007-11-01T21:56:06Z', 'artist': 'Dido', 'title': 'Here With Me', 'album': 'No Angel', 'track': '1', 'date': '2000', 'genre': 'Pop', 'time': '254', 'duration': '254.411', 'pos': '0', 'id': '181'}
{'file': 'Dido/No Angel/disc 1/02. Hunter.mp3', 'last-modified': '2007-11-01T21:56:06Z', 'artist': 'Dido', 'title': 'Hunter', 'album': 'No Angel', 'track': '2', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '236', 'duration': '236.413', 'pos': '1', 'id': '156'}
{'file': "Dido/No Angel/disc 1/03. Don't Think of Me.mp3", 'last-modified': '2007-11-01T21:56:07Z', 'artist': 'Dido', 'title': "Don't Think of Me", 'album': 'No Angel', 'track': '3', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '272', 'duration': '272.149', 'pos': '2', 'id': '182'}
{'file': "Dido/No Angel/disc 1/04. My Lover's Gone.mp3", 'last-modified': '2007-11-01T21:56:07Z', 'artist': 'Dido', 'title': "My Lover's Gone", 'album': 'No Angel', 'track': '4', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '268', 'duration': '267.917', 'pos': '3', 'id': '183'}
{'file': 'Dido/No Angel/disc 1/05. All You Want.mp3', 'last-modified': '2007-11-01T21:56:07Z', 'artist': 'Dido', 'title': 'All You Want', 'album': 'No Angel', 'track': '5', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '234', 'duration': '233.775', 'pos': '4', 'id': '184'}
{'file': 'Dido/No Angel/disc 1/06. Thank You.mp3', 'last-modified': '2007-11-01T21:56:07Z', 'artist': 'Dido', 'title': 'Thank You', 'album': 'No Angel', 'track': '6', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '218', 'duration': '218.362', 'pos': '5', 'id': '185'}
{'file': 'Dido/No Angel/disc 1/07. Honestly Ok.mp3', 'last-modified': '2007-11-01T21:56:07Z', 'artist': 'Dido', 'title': 'Honestly Ok', 'album': 'No Angel', 'track': '7', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '279', 'duration': '278.784', 'pos': '6', 'id': '186'}
{'file': 'Dido/No Angel/disc 1/08. Slide.mp3', 'last-modified': '2007-11-01T21:56:07Z', 'artist': 'Dido', 'title': 'Slide', 'album': 'No Angel', 'track': '8', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '292', 'duration': '292.211', 'pos': '7', 'id': '187'}
{'file': 'Dido/No Angel/disc 1/09. Isobel.mp3', 'last-modified': '2007-11-01T21:56:08Z', 'artist': 'Dido', 'title': 'Isobel', 'album': 'No Angel', 'track': '9', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '234', 'duration': '234.114', 'pos': '8', 'id': '188'}
{'file': "Dido/No Angel/disc 1/10. I'm No Angel.mp3", 'last-modified': '2007-11-01T21:56:08Z', 'artist': 'Dido', 'title': "I'm No Angel", 'album': 'No Angel', 'track': '10', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '236', 'duration': '235.603', 'pos': '9', 'id': '189'}
{'file': 'Dido/No Angel/disc 1/11. My Life.mp3', 'last-modified': '2007-11-01T21:56:08Z', 'artist': 'Dido', 'title': 'My Life', 'album': 'No Angel', 'track': '11', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '180', 'duration': '179.962', 'pos': '10', 'id': '190'}
{'file': 'Dido/No Angel/disc 1/12. Take My Hand.mp3', 'last-modified': '2007-11-01T21:56:08Z', 'artist': 'Dido', 'title': 'Take My Hand', 'album': 'No Angel', 'track': '12', 'date': '2000', 'genre': 'Pop', 'disc': '1', 'time': '402', 'duration': '402.317', 'pos': '11', 'id': '191'}
{'file': 'Dido/No Angel/disc 2/01. Here With Me.mp3', 'last-modified': '2007-12-24T11:35:07Z', 'artist': 'Dido', 'title': 'Here With Me', 'album': 'No Angel', 'track': '1', 'date': '2000', 'genre': 'Pop', 'disc': '2', 'time': '235', 'duration': '235.002', 'pos': '12', 'id': '192'}
{'file': 'Dido/No Angel/disc 2/02. Thank You.mp3', 'last-modified': '2007-12-24T11:26:49Z', 'artist': 'Dido', 'title': 'Thank You', 'album': 'No Angel', 'track': '2', 'date': '2000', 'genre': 'Pop', 'disc': '2', 'time': '566', 'duration': '566.392', 'pos': '13', 'id': '193'}
{'file': 'Dido/No Angel/disc 2/03. Hunter.mp3', 'last-modified': '2007-12-24T11:35:56Z', 'artist': 'Dido', 'title': 'Hunter', 'album': 'No Angel', 'track': '3', 'date': '2000', 'genre': 'Pop', 'disc': '2', 'time': '366', 'duration': '365.980', 'pos': '14', 'id': '194'}
{'file': 'Dido/No Angel/disc 2/04. Take My Hand.mp3', 'last-modified': '2007-12-24T11:41:45Z', 'artist': 'Dido', 'title': 'Take My Hand', 'album': 'No Angel', 'track': '4', 'date': '2000', 'genre': 'Pop', 'disc': '2', 'time': '483', 'duration': '483.166', 'pos': '15', 'id': '195'}
{'file': 'Dido/No Angel/disc 2/05. Christmas Day.mp3', 'last-modified': '2007-11-01T21:56:23Z', 'artist': 'Dido', 'title': 'Christmas Day', 'album': 'No Angel', 'track': '5', 'date': '2000', 'genre': 'Pop', 'disc': '2', 'time': '243', 'duration': '242.630', 'pos': '16', 'id': '196'}

This disc metadata appears to not be provided by MPD any more afterwards.

By "switching between albums" I means clicking on a different albums while the first one missing disc numbers is playing and back again to the initial one. Effectively creating a new playlist.

@Forage
Copy link
Author

Forage commented Aug 26, 2021

I suppose we can call this issue closed as it's an MPD bug instead of mpdevil.

@Forage Forage closed this as completed Aug 26, 2021
@dgcampea
Copy link
Contributor

dgcampea commented Sep 1, 2021

@Forage do forward this issue to MPD upstream as this affects multiple clients

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants