Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album cover fallback #8

Closed
chinmayanagpal opened this issue Jul 30, 2020 · 5 comments
Closed

Album cover fallback #8

chinmayanagpal opened this issue Jul 30, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@chinmayanagpal
Copy link

chinmayanagpal commented Jul 30, 2020

Sometimes, instead of using "cover.jpg" and the like for album covers, "<album artist> - <album name>" is used. Users should be allowed to configure mpdevil to fall back to any images it finds in the same directory as the track, or, better, enter their own regular expression string to find album covers.

@SoongNoonien
Copy link
Owner

What do you mean by

" - " is used

?

...or, better, enter their own regular expression string to find album covers.

I could integrate this feature into the profile settings. But this will take some time since they generally need a small review.

@SoongNoonien SoongNoonien added the enhancement New feature or request label Jul 30, 2020
@chinmayanagpal
Copy link
Author

Sorry, I forgot that the GitHub markdown parser treats <>s specially. Fixed my original comment.

@SoongNoonien SoongNoonien self-assigned this Aug 3, 2020
@SoongNoonien
Copy link
Owner

I did find some time to make a first test. The newest commit implements a regex config in the profile settings. Please let me know if it works as expected.

@chinmayanagpal
Copy link
Author

It works! Thanks so much :)
When can we expect this in a release?

@SoongNoonien
Copy link
Owner

When can we expect this in a release?

I think in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants