Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Tooltip or Semantic Label #34

Closed
tsinis opened this issue Nov 15, 2020 · 6 comments
Closed

Feature request: Tooltip or Semantic Label #34

tsinis opened this issue Nov 15, 2020 · 6 comments

Comments

@tsinis
Copy link
Contributor

tsinis commented Nov 15, 2020

Hey @sooxt98!

Writing to you again! Thank you for the great package, but could you add some semantics? Because at the moment GButton doesn't allow us to add any tooltip or semantic tag, so Accessibility Checker or any other semantic analysis SW will not recognize the meaning of this button... Semantics are articularly helpful for people with visual impairments but are also great for testing. A Tooltip would be perfect, but the semanticLabel property should be okay too.

Thanks!

@tsinis
Copy link
Contributor Author

tsinis commented Nov 16, 2020

I can make PR probably, if you accept. Thanks.

@sooxt98
Copy link
Owner

sooxt98 commented Nov 16, 2020

Hi @tsinis why don't just simply wrap Gbutton with tooltips or semantics?

@tsinis
Copy link
Contributor Author

tsinis commented Nov 16, 2020

Hi @tsinis why don't just simply wrap Gbutton with tooltips or semantics?

Hey! Because GNav "tabs" parameter only accept List<GButton> not List<Widget>. Thanks for reply.

constructor

@sooxt98
Copy link
Owner

sooxt98 commented Nov 20, 2020

@tsinis ah so adding one more Tooltip to GButton would be enough? btw, PR is welcome :3

@tsinis
Copy link
Contributor Author

tsinis commented Nov 20, 2020

@tsinis ah so adding one more Tooltip to GButton would be enough? btw, PR is welcome :3

Ok super. I'll try to push a PR in few days so you can review it. Thanks!

@tsinis
Copy link
Contributor Author

tsinis commented Dec 2, 2020

Thanks for PR merge @sooxt98 ! Wish you good luck with null-safety, stay strong :D

@tsinis tsinis closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants