Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reddit: Support PRAW 7 #1903

Closed
RhinosF1 opened this issue Jul 8, 2020 · 5 comments · Fixed by #2319
Closed

reddit: Support PRAW 7 #1903

RhinosF1 opened this issue Jul 8, 2020 · 5 comments · Fixed by #2319

Comments

@RhinosF1
Copy link
Contributor

RhinosF1 commented Jul 8, 2020

The problem

I can't update praw to version 7
$ pip3 check sopel 7.0.4 has requirement praw<6.0.0,>=4.0.0, but you have praw 7.1.0. praw 7.1.0 has requirement prawcore<2.0,>=1.3.0, but you have prawcore 0.14.0. The command "pip3 check" exited with 1.

The solution

Support the latest version of praw

@dgw
Copy link
Member

dgw commented Jul 8, 2020

But why does it matter?

Haven't checked the API changes for newer PRAW versions, but if you have something else installed that needs more recent PRAW that's kind of what venvs are for.

@RhinosF1
Copy link
Contributor Author

RhinosF1 commented Jul 8, 2020

But why does it matter?

Haven't checked the API changes for newer PRAW versions, but if you have something else installed that needs more recent PRAW that's kind of what venvs are for.

We just like to ensure things are kept up to date. It's 100% low priority and a nice to be.

@dgw dgw changed the title Support Praw 7 reddit: Support PRAW 7 Jul 8, 2020
@dgw
Copy link
Member

dgw commented Jul 8, 2020

Looks like the current praw version range was selected to match Sopel's Python release compatibility as closely as possible without needing to use environment specifiers. Slotting this for 8.0, since we'll be dropping old Pythons then.

(We'll probably also split the reddit plugin out into its own package, but this issue can just be moved to the new repo if that happens first.)

@dgw dgw added this to the 8.0.0 milestone Jul 8, 2020
@deathbybandaid
Copy link
Contributor

I'd also want to thoroughly verify that everything in reddit.py still functions 100% without stripping functionality.

@dgw
Copy link
Member

dgw commented Jul 8, 2020

@deathbybandaid That's (theoretically) why we have tests. Missing examples should be added for code paths that aren't covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants