Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ALT: order book quote should check the limits #1050

Open
OlgaSamorodnova opened this issue May 21, 2024 · 0 comments
Open

[Bug]: ALT: order book quote should check the limits #1050

OlgaSamorodnova opened this issue May 21, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@OlgaSamorodnova
Copy link

Preconditions

  1. There is an order book with limits (f.i., minLotSize=5, maxLotSize=5000)
  2. There are sell limit orders in the order book with sum of amounts > 5000

Steps to reproduce

Send a POST requests with method liquidityProxy_quote:

{
  "id": {{$randomInt}},
  "jsonrpc": "2.0",
  "method": "liquidityProxy_quote",
  "params": [
    0,
    "0x0200040000000000000000000000000000000000000000000000000000000000", //asset id
    "0x0200000000000000000000000000000000000000000000000000000000000000", //XOR
    "1000000000000000000",
    "WithDesiredInput",
    [
      "OrderBook"
    ],
    "AllowSelected"
  ]
}
{
  "id": {{$randomInt}},
  "jsonrpc": "2.0",
  "method": "liquidityProxy_quote",
  "params": [
    0,
    "0x0200040000000000000000000000000000000000000000000000000000000000", //asset id
    "0x0200000000000000000000000000000000000000000000000000000000000000", //XOR
    "6000000000000000000000",
    "WithDesiredInput",
    [
      "OrderBook"
    ],
    "AllowSelected"
  ]
}

Actual behavior

The result is calculated, although there are limits in the orderBook

Expected behavior

Limits should be taken into account

Environment

{"label"=>"Development"}

Operating System

No response

Additional context

No response

@OlgaSamorodnova OlgaSamorodnova added the bug Something isn't working label May 21, 2024
@wer1st wer1st self-assigned this May 21, 2024
@Tieumsan Tieumsan added this to the 4.0.0 - ALT milestone Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants