Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

983/remove assetsconfig from other pallets #1001

Merged
merged 87 commits into from
May 20, 2024
Merged

983/remove assetsconfig from other pallets #1001

merged 87 commits into from
May 20, 2024

Conversation

HaidarJbeily7
Copy link
Contributor

@HaidarJbeily7 HaidarJbeily7 commented Apr 23, 2024 •
edited

  • Replaced usage of assets pallet public functions with AssetManager trait
  • Removed assets::Config from the following pallets:
    • ceres-launchpad
    • ceres-token-locker
    • ceres-liquidity-locker
    • ceres-governance-platform
    • demeter-farming-platform
    • pool-xyk
    • price-tools
    • technical
    • farming
    • vested-rewards
    • rewards
    • faucet
    • kensetsu
    • bridge-proxy
    • qa-tools
    • order-book
    • xst

HaidarJbeily7 and others added 30 commits April 9, 2024 14:03
@HaidarJbeily7
use AssetInfoProvider in ceres-launchpad
1c1cd94
@HaidarJbeily7
use AssetInfoProvider in ceres-token-locker
510175d
@HaidarJbeily7
use AssetInfoProvider in demeter-farming-platform
e7ab0c5
@HaidarJbeily7
use AssetInfoProvider in eth-bridge
1ac7a93
@HaidarJbeily7
use AssetInfoProvider in hermes-governance-platform
de429bc
@HaidarJbeily7
use AssetInfoProvider in liquidity-proxy
e3a5e56
@HaidarJbeily7
use AssetInfoProvider in multicollateral-bonding-curve-pool
39c0a89
@HaidarJbeily7
use AssetInfoProvider in pool-xyk
b94622a
@HaidarJbeily7
use AssetInfoProvider in pswap-distribution
88a3446
@HaidarJbeily7
use AssetInfoProvider in technical
99e1559
@HaidarJbeily7
resolve ambiguous associated type AssetInfoProvider in pswap-distri…
af58b0a 
…bution
@HaidarJbeily7
use AssetInfoProvider in trading-pair
41199a9
@HaidarJbeily7
use AssetInfoProvider in vested-rewards
36494d9
@HaidarJbeily7
update mocks for trustless-bridge, bridge-proxy, eth-app
97d1bcf
@HaidarJbeily7
update mock for kensetsu
33d9cfb
@HaidarJbeily7
update all impl of Config's pallets with the new AssetInfoProvider type
05e7758
@HaidarJbeily7
remove resolved TODO comments
831afc2
@HaidarJbeily7
Merge branch 'master' into 395-tech-debt-use-assetinfoprovider-instea…
2b8ab34 
…d-of-pallet
@HaidarJbeily7
Merge branch 'master' into 395-tech-debt-use-assetinfoprovider-instea…
65895ad 
…d-of-pallet
@HaidarJbeily7
update comments on AssetInfoProvider to be consistent
082f307
@HaidarJbeily7
avoid panic with unwrap() on get_asset_owner impl -> asset pallet
377d19b
@HaidarJbeily7
use AssetInfoProvider in pool-xyk.action_*
6b289da
@HaidarJbeily7
Merge branch 'master' into 395-tech-debt-use-assetinfoprovider-instea…
0207492 
…d-of-pallet
@HaidarJbeily7
Merge branch 'master' into 395-tech-debt-use-assetinfoprovider-instea…
50866a9 
…d-of-pallet
@HaidarJbeily7
remove asset config from ceres-governance-platform, ceres-liquidity-l…
b0e7287 
…ocker, pool-xyk, price-tools, technical
@HaidarJbeily7
remove asset config from multicollateral-bonding-curve-pool
af432a3
@HaidarJbeily7
fix issues in pool-xyk
b9f7d8e
@HaidarJbeily7
remove asset config from ceres-token-locker
d408eae
@HaidarJbeily7
remove asset config from ceres-launchpad
84a85a6
@HaidarJbeily7
remove asset config from demeter-farming-platform
cf401f3
Alexey-N-Chernyshov
Alexey-N-Chernyshov approved these changes May 13, 2024
View reviewed changes
pallets/ceres-launchpad/src/lib.rs Outdated Show resolved Hide resolved
wer1st
wer1st reviewed May 19, 2024
View reviewed changes
pallets/ceres-governance-platform/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/ceres-launchpad/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/ceres-liquidity-locker/src/lib.rs Outdated Show resolved Hide resolved
pallets/dex-manager/Cargo.toml Outdated Show resolved Hide resolved
pallets/farming/Cargo.toml Outdated Show resolved Hide resolved
pallets/technical/Cargo.toml Outdated Show resolved Hide resolved
pallets/vested-rewards/Cargo.toml Outdated Show resolved Hide resolved
pallets/xor-fee/Cargo.toml Outdated Show resolved Hide resolved
common/src/traits.rs Outdated Show resolved Hide resolved
common/src/traits.rs Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 20, 2024
View reviewed changes
pallets/farming/src/benchmarking.rs Fixed Show fixed Hide fixed
pallets/farming/src/benchmarking.rs Fixed Show fixed Hide fixed
pallets/farming/src/benchmarking.rs Fixed Show fixed Hide fixed
@HaidarJbeily7 HaidarJbeily7 requested a review from wer1st May 20, 2024 13:21
@HaidarJbeily7 HaidarJbeily7 merged commit da0b88e into master May 20, 2024
6 checks passed
@HaidarJbeily7 HaidarJbeily7 deleted the 983/remove-assetsconfig-from-other-pallets branch May 20, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexey-N-Chernyshov Alexey-N-Chernyshov Alexey-N-Chernyshov approved these changes

@wer1st wer1st wer1st approved these changes

@vovac12 vovac12 Awaiting requested review from vovac12

@stefashkaa stefashkaa Awaiting requested review from stefashkaa

@Nikita-Polyakov Nikita-Polyakov Awaiting requested review from Nikita-Polyakov

Assignees

@HaidarJbeily7 HaidarJbeily7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tech]: Remove assets::Config from another pallets
3 participants
@HaidarJbeily7 @Alexey-N-Chernyshov @wer1st