Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: substrateBridgeApp.WrongAmount when user trasnfers with wrong dimension #146

Open
ra9mls opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@ra9mls
Copy link

ra9mls commented Sep 22, 2023

Preconditions

User has a ROC tokens

Steps to reproduce

Call data:
0x6700010300dc9b4341fde46c9ac80b623d0d43afd9ac205baabdc087cadaa06f92b309c7020301010100bcc5ecf679ebd776866a04c212a4ec5dc45cefab57d7aa858c389844e212693fe040944dff51970f0000000000000000

Actual behavior

User sees error substrateBridgeApp.WrongAmount
https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fws.framenode-2.s1.stg1.sora2.soramitsu.co.jp#/explorer/query/0xb8954820ca19ae0a40fad4fd401692de99f048aa21baf25e9f9b04bdaea4f6db

Expected behavior

??? When user inputs 1123456789012300000 with larger dimension (ROC has 12) it need to be converted according asset

Environment

{"label"=>"Development"}

Operating System

No response

Additional context

No response

Aha! Link: https://soramitsucoltd.aha.io/features/SKP-6

@ra9mls ra9mls added the bug Something isn't working label Sep 22, 2023
@bgodlin
Copy link

bgodlin commented Sep 25, 2023

@ra9mls please check for duplication with #117

@ra9mls
Copy link
Author

ra9mls commented Sep 25, 2023

Some problems can be if it works with token with 21 precision. When user will send this token and it will be applied with fee, this transfer will be failed because sora has 18 precision.

@Tieumsan
Copy link
Contributor

@N1ghtStorm @ra9mls what is the status of this task ?
Has it been fixed ?

cc. @vovac12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

4 participants