FLW-1317 Analytics UI/UX improvements #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ef1rspb
commented
Oct 5, 2021
•
ef1rspb
commented
- remove pinch-to-zoom from Rewards tab
- Analytics widget: KSM crosses month on OX (especially on small screen)
- Validators: doesn't fit into circle diagram, if validator doesn't have display name
- Validators: label"Staking was inactive" is smaller than "Staking was active”
- Staking tab: fix chart drops
- History: "Your rewards will appear hear" text is not relevant here, we need to change empty state to another text
… have display name
Codecov Report
@@ Coverage Diff @@
## develop #408 +/- ##
===========================================
+ Coverage 31.43% 34.31% +2.88%
===========================================
Files 462 560 +98
Lines 19656 24953 +5297
===========================================
+ Hits 6179 8563 +2384
- Misses 13477 16390 +2913
|
ERussel
reviewed
Oct 6, 2021
| } | ||
| }() | ||
| let currentDate = calendar.date(byAdding: component, to: timestampInterval.0) ?? startDate | ||
| let stakeChangesForCurrentDate = groupedByDate.map { date, stakeChanges -> (Date, [SubqueryStakeChangeData])? in |
There was a problem hiding this comment.
Why not directly apply compactMap instead of map.compactMap?
ERussel
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.