Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor session keys #1605

Merged
merged 13 commits into from May 16, 2023
Merged

Refactor session keys #1605

merged 13 commits into from May 16, 2023

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • intersect keystore with babe/gran/para/audi authorities for block

Benefits

  • babe/gran work after rotateKeys without restarting node

Possible Drawbacks

@turuslan
audi
2c71271 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
para
66b4fc2 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
babe
c07635b 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
cache
b68b07e 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
Merge remote-tracking branch 'origin/master' into refactor/session-keys
d45c475
@turuslan
gran
d10fb54 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
fix example
b677bab 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
kamilsa
kamilsa reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@kamilsa kamilsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update caching of session keys, so that we remember index of where authority key was positioned last time. If it is not there, we can iterate through all keys

core/authority_discovery/publisher/address_publisher.cpp Outdated Show resolved Hide resolved
@turuslan
pr comment
8cdf93d 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
cache index
81e5251 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
one two
2647ac4 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from kamilsa May 12, 2023 10:15
@kamilsa kamilsa requested a review from Harrm May 12, 2023 11:47
Harrm
Harrm reviewed May 13, 2023
View reviewed changes
core/crypto/crypto_store/session_keys.hpp Outdated Show resolved Hide resolved
core/crypto/crypto_store/session_keys.cpp Outdated Show resolved Hide resolved
@turuslan
using
c5e0725 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan
Merge remote-tracking branch 'origin/master' into refactor/session-keys
c43d348
@turuslan
rename
e0f06cc 
Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from Harrm May 16, 2023 09:48
@turuslan turuslan enabled auto-merge (squash) May 16, 2023 10:15
@turuslan turuslan merged commit 5710bbb into master May 16, 2023
9 of 15 checks passed
@turuslan turuslan deleted the refactor/session-keys branch May 16, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilsa kamilsa kamilsa approved these changes

@Harrm Harrm Harrm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@turuslan @kamilsa @Harrm