Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated chromedriver #72

Closed
fengyuan213 opened this issue Dec 19, 2022 · 4 comments · Fixed by #76
Closed

Outdated chromedriver #72

fengyuan213 opened this issue Dec 19, 2022 · 4 comments · Fixed by #76

Comments

@fengyuan213
Copy link

Hello, I am tring to download a lectures through SSO, the webdriver said "RESPONSE InitSession unknown error: cannot find Chrome binary" in webdriver_service.log, I have the error fixed and logd in by redownloading the lastest compaticable chromedriver and put it into bin/chromedriver.exe .it worked, Is it possible maybe update the download address of chrome driver?
Here is the link:https://chromedriver.chromium.org/downloads

@soraxas
Copy link
Owner

soraxas commented Dec 19, 2022

Does it works if you edit the target version in the following file?
https://github.com/soraxas/echo360/blob/master/echo360/binary_downloader/chromedriver.py

I think the chrome driver might be dependent on the installed chrome, so fixing on latest version might also break earlier chrome version.

I would be happy to accept PR if it is possible to determine the current installed chrome and download the corresponding necessary chrome driver

@jbatesy
Copy link

jbatesy commented Mar 1, 2023

The code should consider installed version & pick appropriately, the geckodriver install is also affected by this. It also didn't check all locations on my $PATH as I already had geckodriver on $PATH.

Will likely pick this up and make a PR.

@soraxas
Copy link
Owner

soraxas commented Mar 1, 2023 via email

@soraxas soraxas linked a pull request Dec 4, 2023 that will close this issue
@soraxas
Copy link
Owner

soraxas commented Dec 4, 2023

closes by #76

@soraxas soraxas closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants