Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE: Faster workspace/symbol #5009

Open
jvilk-stripe opened this issue Dec 14, 2021 · 0 comments
Open

IDE: Faster workspace/symbol #5009

jvilk-stripe opened this issue Dec 14, 2021 · 0 comments
Labels
enhancement New feature or surprising current feature good first issue Good for newcomers IDE Relating to Sorbet's LSP server or VS Code extension

Comments

@jvilk-stripe
Copy link
Collaborator

Problem

workspace/symbol is slow on large projects. It attempts to support IntelliJ-style prefix searches and orders results as such, but we do not control the order of the results -- VS Code reorders results itself.

Proposed solution

So long as it is cheaper to compute, support a simpler substring search instead. For Stripes tackling this project: It may be worth mining Stripe engineer logs to verify that users are not expecting the IntelliJ-like behavior.

@jvilk-stripe jvilk-stripe added enhancement New feature or surprising current feature good first issue Good for newcomers IDE Relating to Sorbet's LSP server or VS Code extension labels Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or surprising current feature good first issue Good for newcomers IDE Relating to Sorbet's LSP server or VS Code extension
Projects
None yet
Development

No branches or pull requests

1 participant