Audit bash scripts to use "unofficial bash strict mode" in more places

[jez]

We have a lot of bash scripts.

We should be using set -euo pipefail in ~all of them. We are currently not doing this nearly as much as we should.

For more information on why to use set -euo pipefail, see here:

http://redsymbol.net/articles/unofficial-bash-strict-mode/

(note: i disagree with the IFS suggestions in that article; there are enough legitimate uses for " " as an IFS that warrant not making that the default. Also, shellcheck is much better at warning you for places where having " " in the IFS list might lead to surprising behavior. this is not the case for the set options).

[azdavis-stripe]

Should we also converge on a single shebang? I see

• #!/bin/bash
• #!/bin/sh
• #!/usr/bin/env bash