Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete jank when typing # typed: true #7835

Open
jez opened this issue Apr 15, 2024 · 0 comments
Open

Autocomplete jank when typing # typed: true #7835

jez opened this issue Apr 15, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers IDE Relating to Sorbet's LSP server or VS Code extension

Comments

@jez
Copy link
Collaborator

jez commented Apr 15, 2024

Observed output

Screen.Recording.2024-04-15.at.3.45.40.PM.mov

Expected behavior

Sorbet should not delete what you've typed when you accept the autocomplete suggestion.


We’re like absolutely abusing the LSP completion interface for the purpose of showing that little “hey there! you’re need a # typed: sigil!” message

I have a feeling that if we make this say “you need to call resolve to resolve this completion item” we can make it do the right thing?

I think possibly this pushes the problem around, because I think it’ll mean that every keystroke in a # typed: false file will send a textDocument/completion request which might be orders of magnitude more requests than we get now, but maybe it doesn’t matter?

@jez jez added bug Something isn't working good first issue Good for newcomers IDE Relating to Sorbet's LSP server or VS Code extension labels Apr 15, 2024
@jez jez added this to the Autocompletion milestone Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers IDE Relating to Sorbet's LSP server or VS Code extension
Projects
None yet
Development

No branches or pull requests

1 participant