Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap: Modal #71

Closed
joaquinsoza opened this issue Jul 26, 2023 · 0 comments
Closed

Swap: Modal #71

joaquinsoza opened this issue Jul 26, 2023 · 0 comments
Assignees
Milestone

Comments

@joaquinsoza
Copy link
Collaborator

joaquinsoza commented Jul 26, 2023

Add a review swap modal, same as the one in uniswap for now. should popup after clicking swap button, if #70 is already working the swap function should be called after this popup

Image

i think this same modal changes after to a waiting for confirmation ( waiting for the user to sign the transaction in the wallet) and then it turns into a transaction submitted, so research how uniswap modal works, we should bring the logic to our app

Please refer to uniswap interface for the styled components and how the component is compose. I've been running this project locally to see the files and its workings.

@joaquinsoza joaquinsoza added this to the Swap Section milestone Jul 26, 2023
@esteblock esteblock changed the title Review Swap Modal Swap Modal Aug 2, 2023
@esteblock esteblock changed the title Swap Modal Swap: Modal Aug 2, 2023
@joaquinsoza joaquinsoza self-assigned this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants