Use const fn instead of const macros #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want to review the large diffs of |
sorpaas
commented
Mar 24, 2020
| @@ -11,5 +11,5 @@ matrix: | |||
| - beta | |||
| script: | |||
| - cargo build --verbose --all | |||
| - cargo test --verbose --all | |||
| - cargo test --verbose | |||
There was a problem hiding this comment.
The noconst feature is currently necessary for gen_ecmult and gen_genmult, but if it's enabled, then tests won't work, because nearly all user-facing functions depend on those constants. In the future, switching to build script will fix this.
drahnr
reviewed
Mar 24, 2020
drahnr
reviewed
Mar 24, 2020
|
I am not sure if the failing tests are ok, I also did not review the generated files full of constants. |
|
@drahnr Which tests are failing? |
drahnr
approved these changes
Mar 24, 2020
|
Nevermind, looks good to me :) |
trevor-crypto
pushed a commit
to monacohq/libsecp256k1
that referenced
this pull request
May 31, 2022
* Use const fn instead of const macros * Build and test only main crate * Still able to build all, but not test all * Add description how Field n value is stored * Clarify that the least signficant bit is in the front * Bit -> byte
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
field_const,field_storage_const,field_const_raw,affine_const,jacobian_constmacros, and replaces them with const fnsField::new,FieldStorage::new,Field::new_raw,Affine::new,Jacobian::new.