Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creates space at the top of the page #7

Closed
SirRawlins opened this issue Jan 4, 2016 · 1 comment
Closed

Creates space at the top of the page #7

SirRawlins opened this issue Jan 4, 2016 · 1 comment
Assignees
@SirRawlins
Labels
bug

Comments

@SirRawlins
Copy link
Contributor

We have had a report from a customer to say that they have an issue with the latest build whereby it creates a small gap at the top of the browser window even when no notices are being displayed.

I've attached a redacted screenshot which they were kind enough to send over. We need to try and repo this ourselves and then patch it.

line
@SirRawlins SirRawlins added the bug label Jan 4, 2016
@SirRawlins SirRawlins self-assigned this Jan 4, 2016
@SirRawlins
Copy link
Contributor Author

O.k so this appears to be a result of the border-bottom style which is applied to the bar through the stylesheet. https://github.com/sorry-app/status-bar/blob/master/src/stylesheets/status-bar.css#L15

This must have just been an oversight on my part. I'll get this pulled out before too long.

@SirRawlins SirRawlins mentioned this issue Jan 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SirRawlins SirRawlins

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SirRawlins