Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display began_at/ended_at timestamps on notices #105

Closed
SirRawlins opened this issue Dec 2, 2019 · 2 comments
Closed

Display began_at/ended_at timestamps on notices #105

SirRawlins opened this issue Dec 2, 2019 · 2 comments

Comments

@SirRawlins
Copy link
Contributor

At the moment we use the update.created_at timestamp next to comments, to show when they were posted. However, we don't include the actual began_at/ended_at timestamps.

This is particularly noticeable when historic incidents are added to the page, as their true start/end time isn't displayed, only the time the notice was added to the page.

@SirRawlins
Copy link
Contributor Author

The first steps towards this were adding in 2.44.1 which just includes the began/ended timestamp alongside the duration in the "timeliness" section of the notice.

We'll next be looking at some style changes to updates to make the date/time they were posted less dominant.

@SirRawlins
Copy link
Contributor Author

While doing some more QA I actually found a bug in that last PR, and 2.44.1 so have reverted the changes until I get time to properly address it. 2.44.2 is the latest stable release, and matches 2.44.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant