Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "lookpath" package #668

Closed
wants to merge 1 commit into from
Closed

Add "lookpath" package #668

wants to merge 1 commit into from

Conversation

otiai10
Copy link

@otiai10 otiai10 commented Feb 7, 2020

Background

When we google "how to check if a command exists in nodejs", many inefficient ways are suggested with spawning subprocesses.

This package provides the simplest way to do that WITHOUT depending on other binaries.

Links

discussion: https://stackoverflow.com/a/56321089/1368868
github.com repo: https://github.com/otiai10/lookpath
npmjs.org: https://www.npmjs.com/package/lookpath
coverage service link: https://codecov.io/gh/otiai10/lookpath

Thanks you for facilitating, you're awesome! 馃憤

@otiai10
Copy link
Author

otiai10 commented May 28, 2020

@otiai10
Copy link
Author

otiai10 commented May 28, 2020

Hi @gokaygurcan , I saw some of your comments mentioning "not-acceptable for low-stared repos" policy.
I'm not that enthusiastic to get this PR merged 馃槄, but I want to know more "awesome" solution for this purpose. If you know something, please let me know 馃檹

@andreasonny83
Copy link
Collaborator

I can agree with @gokaygurcan in saying this PR is not ready to be merged since the lookpath only holds a couple of stars.
I would suggest to close this issue for now and reopen in the future if that package become "awesome"

@otiai10
Copy link
Author

otiai10 commented May 28, 2020

@andreasonny83 Thank you for your comment. Sounds fair enough for me.
By the way, do you know better solution for this purpose? I need to know something "awesome" on this topic.

@andreasonny83
Copy link
Collaborator

andreasonny83 commented May 28, 2020

All you can do is to promote lookpath and make sure the project gets a least 1k stars on GitHub, then you should be able to re-open this ticket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants