Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular 12 #242

Open
nunoarruda opened this issue Aug 24, 2021 · 9 comments
Open

Support Angular 12 #242

nunoarruda opened this issue Aug 24, 2021 · 9 comments

Comments

@nunoarruda
Copy link

Looks to be working ok with Angular 12 but there's a warning on npm install about peer dependencies:

npm WARN ngx-sortablejs@11.1.0 requires a peer of @angular/common@^11.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN ngx-sortablejs@11.1.0 requires a peer of @angular/core@^11.0.0 but none is installed. You must install peer dependencies yourself.
@Anikethana
Copy link

pull request #246

@nunoarruda
Copy link
Author

Node.js LTS version is now v16.x which includes npm v8.x. These versions will error out on npm install if there is an incorrect (and potentially broken) dependency resolution which looks to be the case with ngx-sortablejs:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: pulse-angular@5.2.4
npm ERR! Found: @angular/common@12.2.12
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"~12.2.11" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^11.0.0" from ngx-sortablejs@11.1.0
npm ERR! node_modules/ngx-sortablejs
npm ERR!   ngx-sortablejs@"^11.1.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/nunoarruda/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/nunoarruda/.npm/_logs/2021-11-02T15_53_02_208Z-debug.log

Workaround: use npm install --force or npm install --legacy-peer-deps.

@smnbbrv can you please fix this when you have a chance?

@arimus
Copy link

arimus commented Nov 28, 2021

It might be appropriate to not depend on a specific version of Angular and do a greater than the min requirements as a peer dependency instead? Would prevent having to create new builds for every Angular release.

@imtiazShakil
Copy link

is this project dead?

@nunoarruda
Copy link
Author

At this stage, it looks like this project is pretty much dead and/or abandoned. I suggest you folks give these alternatives a try:

https://material.angular.io/cdk/drag-drop/overview (for mixed direction, follow MikaStark workaround)
https://valor-software.com/ng2-dragula/
https://kreuzerk.github.io/ng-sortgrid/

@COBRASoft5
Copy link

cdk doesn't work with grids
dragula also dead
sortgrid doesn't cut it

SortableJs is the best available, but it needs to be maintained :(

@Deitsch
Copy link

Deitsch commented Nov 23, 2022

Yes, it's dead.
I'd suggest https://github.com/ThibaultJanBeyer/DragSelect as alternative

@SylvainUMI
Copy link

Holly shit it's too bad ....

@nzbin
Copy link

nzbin commented Aug 2, 2023

Hi, folks, I suggest you can try the ng-dnd library and it's very easy to solve the mixed direction issue (angular/components#13372), please check the following example:
https://stackblitz.com/edit/867pxw?file=src%2Fexample%2Fchips-drag-drop-example.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants