Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Android back button leaves dialog open #47

Closed
AlexMcConnell opened this issue Jun 8, 2022 · 2 comments
Closed

Bug: Android back button leaves dialog open #47

AlexMcConnell opened this issue Jun 8, 2022 · 2 comments

Comments

@AlexMcConnell
Copy link

Load up the example app on Android. Go to the examples page and open any of the dialogs. Click the Android back button. The page navigates back, but the dialog is still open. The user can close it from there, but that's pretty awful UX.

@sososdk
Copy link
Owner

sososdk commented Jun 9, 2022

When persistent is true, the dialogs is global.

Set persistent to false, the FlashDialog will add to route, and can be closed through the back button.

Please refer to the usage of persistent.

@AlexMcConnell
Copy link
Author

Which in turn requires me to add a bunch of Overlay code. :-\

Maybe it's not technically a bug, but I don't like it. :D

@sososdk sososdk closed this as not planned Won't fix, can't repro, duplicate, stale Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants