Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--upload-protocol for s3 #3112

Closed
TrevorBenson opened this issue Jan 13, 2023 · 2 comments · Fixed by #3447
Closed

--upload-protocol for s3 #3112

TrevorBenson opened this issue Jan 13, 2023 · 2 comments · Fixed by #3447

Comments

@TrevorBenson
Copy link
Member

TrevorBenson commented Jan 13, 2023

I'm interested in extending the functions for --upload-protocol such that collector and report would both have available:

              {{module}}_grp.add_argument("--upload-protocol", default='auto',
                                 choices=['auto', 'https', 'ftp', 'sftp', 's3'],

Would an s3 protocol upload option be a welcome addition? If so I will create a branch and a draft PR for further discussion.

Thanks

@TurboTurtle
Copy link
Member

Absolutely. I'm not sure if our current upload credentials are sufficient for s3 (just username/password at the moment), but if you have a use case for end users uploading to s3 then by all means feel free to open a PR.

@TrevorBenson
Copy link
Member Author

Great.

I believe--upload-user & --upload-pass could be used as the AWS access and secret key of the s3 protocol, but I will review to see if I overlooked some constraints which would otherwise prevent it.

Many of the other --upload-[...] arguments I believe should easily map between protocols. The region would be a new argument and possibly a bucket, but I need to review --upload-url as given https as a protocol it may be flexible enough to handle both virtual host and path style s3 requests.

@TrevorBenson TrevorBenson changed the title Would an --upload-protocol for s3 be a welcomed feature? --upload-protocol for s3 Jan 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants