Skip to content
This repository has been archived by the owner on Oct 3, 2021. It is now read-only.

Continuous integration for "compilable check" #37

Closed
delcypher opened this issue Oct 9, 2015 · 7 comments
Closed

Continuous integration for "compilable check" #37

delcypher opened this issue Oct 9, 2015 · 7 comments

Comments

@delcypher
Copy link
Member

@dbeyer @tautschnig

I was looking other some stuff in the repository and I notice you seem to be having some problems with benchmarks that don't compile properly with warnings enabled. I have a suggestion to try to prevent this from getting any worse.

  1. Create an actual set of Makefiles that will actually make it easy to compile the benchmarks individually or all together. Some of the makefiles would mark the benchmarks that are blacklisted.
  2. Add TravisCI (free continuous integration service for open source repositories) to this repository to run this makefile for every PR or commit to prevent additional benchmarks being introduced that don't conform.

I'm currently trying to see if I can get KLEE to symbolically execute some of the benchmarks some I going to be doing step 1 anyway and I have lots of experience using TravisCI so I'm happy to set that up as well if it is desired.

@PhilippWendler
Copy link
Member

I am also in favor of using TravisCI for this. I don't think makefiles are necessary, we can just run the existing script (maybe with some tweaks).

@delcypher
Copy link
Member Author

@PhilippWendler Well I went ahead and made a Makefile build system anyway because it's more convenient to use and extend IMHO.

@dbeyer
Copy link
Member

dbeyer commented Oct 11, 2015

@dan Could you please add a .travis.yml? I have added the repository on the TravisCI site and the web hook is there, too.

@dbeyer
Copy link
Member

dbeyer commented Oct 11, 2015

@delcypher @PhilippWendler I added both of you as Collaborator such that you are able to help me set up TravisCI. Thanks!

@delcypher
Copy link
Member Author

@dbeyer I will do but I'm still checking that things compile under GCC and Clang. I'm concerned that TravisCI won't actually be suitable here because of the huge number of benchmarks leading to large compile times.

@PhilippWendler
Copy link
Member

@delcypher I think it should be possible somehow to check only files that were changed by commit or pull request when we execute the check on Travis. So if the full check is too costly, we could try to do this.

@delcypher
Copy link
Member Author

This is now done. We finally had a passing build as of eea2e11

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

3 participants