Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we support swift-log and swift-metrics #166

Closed
adam-fowler opened this issue Dec 17, 2019 · 4 comments
Closed

Should we support swift-log and swift-metrics #166

adam-fowler opened this issue Dec 17, 2019 · 4 comments
Projects
Milestone

Comments

@adam-fowler
Copy link
Member

adam-fowler commented Dec 17, 2019

There is a push for many swift server libraries to integrate with standard swift server components like swift-log and swift-metrics. Do we want to do this?

We already have a AWSLoggingMiddleware() but that just has a callback to deal with logging information and there is no logging level. We could change this to take a Logger and provide some level of control over what is output instead.

If we were to integrate swift metrics what would we want to measure? Errors, response time?

Do we want more dependencies on this project?

@fabianfett
Copy link
Contributor

If we want to ensure aws-sdk-swift is also a good citizen on iOS, we should be really careful here.

@adam-fowler
Copy link
Member Author

If we want to ensure aws-sdk-swift is also a good citizen on iOS, we should be really careful here.

good point

@Yasumoto
Copy link
Member

Would love to see support for RED metrics (Requests, Error Rate, Duration) to track each request we send.

@adam-fowler adam-fowler added this to To do in v5.0.0 via automation Jan 20, 2020
@adam-fowler adam-fowler added this to the 5.0.0 milestone Jan 20, 2020
@adam-fowler
Copy link
Member Author

@Yasumoto PR #245 implements RED metrics

v5.0.0 automation moved this from To do to Done May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v5.0.0
  
Done
Development

No branches or pull requests

3 participants