Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary block_on() calls in swapchain chapter #30

Closed
JasonKraft opened this issue Apr 26, 2020 · 1 comment
Closed

Unnecessary block_on() calls in swapchain chapter #30

JasonKraft opened this issue Apr 26, 2020 · 1 comment

Comments

@JasonKraft
Copy link

I'm currently following the chapter on setting up the swapchain and noticed some inconsistencies in how the State struct is implemented from how it's referenced in the main event loop.

Namely the update, render, and resize functions are not asynchronous, so you shouldn't need to include block_on() in event loop. Was the intent for them to be asynchronous, or should the event loop code in the tutorial be updated?

@sotrh
Copy link
Owner

sotrh commented Apr 29, 2020

Update, render, and resize were originally async, but I realized that I wasn't using any async methods in them, so they are no longer async. The tutorial event loop code needs to be updated.

@sotrh sotrh closed this as completed in 57ff442 May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants