Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache TW pages #80

Closed
soul4soul opened this issue Aug 14, 2022 · 0 comments
Closed

Cache TW pages #80

soul4soul opened this issue Aug 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@soul4soul
Copy link
Owner

soul4soul commented Aug 14, 2022

When developing the converter I hit the wiki thousands of times a day. Each run of the program is over 2000 network requests. These requests are slow, waste bandwidth, and appear to cause throttling. One technique I use between runs is using a hard coded list of monsters to avoid all the network requests. A better solution would be to locally cache the wiki pages next to the executable to make them easy to manage and clear.

Expectations:

  • Cache TW pages in plain text
  • Store cache files local to executable in a folder
  • Skip network request when file is found in local cache
  • Optional: TTL for cache to go to network when files are over 24 hours old

The improvement is a nice to have, it mainly helps developers. For end users, that use TW as an input source there is no reason to run the tool more then once a day, even once a week is enough in most cases as the data on the wiki is updated slowly.

@soul4soul soul4soul added the enhancement New feature or request label Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant