Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support to toggle sidebar #31

Closed
KorigamiK opened this issue Apr 21, 2024 · 11 comments
Closed

support to toggle sidebar #31

KorigamiK opened this issue Apr 21, 2024 · 11 comments
Labels
enhancement New feature or request

Comments

@KorigamiK
Copy link

some shortcut to toggle to show the sidebar and expand would be great

@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 21, 2024

I would like to have it too, like this:

  1. You have normal vertical bar auto expand on hover
  2. On some hotkey press, the panel would expand nonetheless of mouse position, and take space from the main browser panel. (Similar to Arc)

But this can't be done in CSS alone, as CSS doesn't detect keystrokes whatsoever. We would need extensions on top of this theme like this one. That is fine, but will only be okay as an optional function, as the user needs to manually tweaks things there. But support for this still has to be done somehow.

So, I can't promise this will be implemented, but I will try mentioned extension, to create prototype if this even works.

@soulhotel
Copy link
Owner

soulhotel commented Apr 21, 2024

But this can't be done in CSS alone, as CSS doesn't detect keystrokes whatsoever. We would need extensions on top of this theme like this one. That is fine, but will only be okay as an optional function, as the user needs to manually tweaks things there. But support for this still has to be done somehow.

userChrome toggle* definitely for this, you can also open the sidebar with ctrl+b for bookmarks, F1 for sidebery, ctrl+shift+o for library.

@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 23, 2024

Ok, confirmed it in test bed repo, it works well, even animating transition is somewhat possible. The only challenge would be to implement it in this theme, but I can try.
Even changing shortcut is possible in user chroma changer, so it would well accessible enough.

@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 23, 2024

Okay, branch userchrome-toogler has this functionality implemented for testing purpose, if anyone would want to check it out.

Also, it appears that autohide is broken with tabs width set to S, is that intentional? @soulhotel

@Kaedriz Kaedriz closed this as completed Apr 23, 2024
@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 23, 2024

Okay, branch userchrome-toggler has this functionality implanted for testing purposes.
In order to use it, you must download this extension first.
The default shortcut for toggling the vertical bar is Shift + Control + 1. AFAIK, you can change it out in Firefox Extensions Shortcuts.

In order to test, I used the following settings:
ultima.tabs.autohide set to false
ultima.tabs.xs set to true

userchrome-toggle.test.webm

Also, is autohide broken when tabs width set to S intentional? @soulhotel
EDIT: Ah, nvm, it was probably my test code that overwrote that.

Another potential feature coming from this would be a totally hidden vertical bar, shown only when toggled.

@Kaedriz Kaedriz reopened this Apr 23, 2024
@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 23, 2024

Sorry, misclicked completed somehow, didn't notice earlier.
The feature is still in development.
If you want to test it out, check above.

@KorigamiK
Copy link
Author

Yeah I got this to work. Userchrome toggle is a nice solution and works nice

@soulhotel
Copy link
Owner

I'd say this can be merged in right away, the code wont break anything, and its structured specifically for UT (title preface). Good with 126.0b3 also, which has broken a couple of other things in this past week.

@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 23, 2024

Well, I used !important to simply test things out without care for hierarchy. Maybe it could integrate better with existing code. Conditional support for it, maybe.

@soulhotel
Copy link
Owner

Well, I used !important to simply test things out without care for hierarchy. Maybe it could integrate better with existing code. Conditional support for it, maybe.

Where it says titlepreface ="", i dont want to mess with the code but it has an invisible character there right?

@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 23, 2024

Well, I used !important to simply test things out without care for hierarchy. Maybe it could integrate better with existing code. Conditional support for it, maybe.

Where it says titlepreface ="", i dont want to mess with the code but it has an invisible character there right?

Yes, it slightly messes Title applets on Linux, and maybe Mac, but it's doable.
image

VSCode should warn you about it, mine does.

@Kaedriz Kaedriz added the enhancement New feature or request label Apr 24, 2024
@soulhotel soulhotel mentioned this issue May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants