Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mac #30

Closed
rainlycoris opened this issue Apr 21, 2024 · 21 comments
Closed

support mac #30

rainlycoris opened this issue Apr 21, 2024 · 21 comments
Labels
bug Something isn't working

Comments

@rainlycoris
Copy link

Although readme wrote that supported mac, but completely broken.

@rainlycoris
Copy link
Author

Do you have a plan to support? Thanks.

@Kaedriz
Copy link
Collaborator

Kaedriz commented Apr 21, 2024

Can you post a screenshot of how it at least looks on Mac? In my understanding, no dev here has mac, so it will be hard doing it blindly, but we could try.
What is broken specifically?

@Kaedriz Kaedriz added the bug Something isn't working label Apr 24, 2024
@rainlycoris
Copy link
Author

截屏2024-04-28 13 43 42 Sorry for the late reply(((

Problems such as the lack of a delete key in the TAB and the placement of some buttons such as the full-screen button are strange

@soulhotel
Copy link
Owner

Aw i see, margins fixed, and title buttons are positioned to the left side in the 1.7.3 release. You can replace the original file with this updated file to replace it, or you can just try the new 1.7.3: https://github.com/soulhotel/FF-ULTIMA/releases/tag/1.7.3

Also check to verify that your firefox is using system default light/dark, instead of firefoxs custom light mode.

@DD1TTY
Copy link

DD1TTY commented Apr 30, 2024

I just installed this theme on my MacBook and no matter which modification settings I use, I am not able to get the built-in vertical tabs working; instead they show up as a horizontal tab bar beneath the bookmarks bar. I would prefer to use your vertical tab theme instead of relying on an extension like Sideberry. Any suggestions?

Screenshot 2024-04-30 at 9 36 48 AM

@soulhotel
Copy link
Owner

soulhotel commented May 1, 2024

I am not able to get the built-in vertical tabs working;

Thats odd, so far I have two others that have the vertical tabs, yet you dont.

Your user.js is applied correctly, but your buttons are on the right still, but the latest theme has them on the left again for mac. I think you downloaded the theme right before i patched 1.7.3 so you should try getting the patched theme.

But that doesnt explain the tabs not displaying correctly. I notice you have the tabs overview button visible. But this is disabled multiple times especially in the vertical tabs file. So either you have a previous theme contradicting the code in this theme. Or something in your browser settings/config is overriding tab related elements in the browser.

Some useful info may be,

  • any previous themes you might have had
  • any modifications you may have done to the about:config before
  • Firefox edition (default release, dev edition, etc)

Definitely redownload, and keep me updated if you can.

@Kaedriz
Copy link
Collaborator

Kaedriz commented May 1, 2024

Mac edition could also have sight differences. One I could think of is context menu. On Linux/Win we have icons, but on Mac, Mozilla just put text, something about native menus going on here. But dunno if this has any connection to this particular issue, just a side note.

Before, custom context menu:

After, native menu:

@soulhotel
Copy link
Owner

Mac edition could also have sight differences. One I could think of is context menu...

Oh wow, okay. Ive been trying all day yesterday to get a couple of Mac ISOs to run in VB, but my amd passthrough couldnt get past the final installer... I might just have to cut support for Mac short if i cant find a way to test on the OS. Fortunately the titlebar is good, but if that ends up being the case, Mac Users may have to settle on using the theme with sidebery and the native tabs disabled.

@Kaedriz
Copy link
Collaborator

Kaedriz commented May 1, 2024

Well, that what also I wanted to do, but finding relatively latest Mac ISO wasn't easy. Didn't want to download from first found site, as that is just begging for viruses. Also have an AMD, so bummer.

@DD1TTY
Copy link

DD1TTY commented May 1, 2024

I am not able to get the built-in vertical tabs working;

Thats odd, so far I have two others that have the vertical tabs, yet you dont.

Your user.js is applied correctly, but your buttons are on the right still, but the latest theme has them on the left again for mac. I think you downloaded the theme right before i patched 1.7.3 so you should try getting the patched theme.

But that doesnt explain the tabs not displaying correctly. I notice you have the tabs overview button visible. But this is disabled multiple times especially in the vertical tabs file. So either you have a previous theme contradicting the code in this theme. Or something in your browser settings/config is overriding tab related elements in the browser.

Some useful info may be,

* any previous themes you might have had

* any modifications you may have done to the about:config before

* Firefox edition (default release, dev edition, etc)

Definitely redownload, and keep me updated if you can.

Hi soulhotel, I just removed all my extensions and themes, deleted my profile folder, uninstalled/reinstalled Firefox ESR 115, and applied the latest version of FF-ULTIMA and I again get the tabs bar along the top. I have not made any changes to about:config

@DD1TTY
Copy link

DD1TTY commented May 1, 2024

    Thats odd, so far I have two others that have the vertical tabs, yet you dont.
    Your user.js is applied correctly, but your buttons are on the right still, but the latest theme has them on the left again for mac. I think you downloaded the theme right before i patched 1.7.3 so you should try getting the [patched theme](https://github.com/soulhotel/FF-ULTIMA/releases/download/1.7.3/ffultima1.7.3.zip).
    But that doesnt explain the tabs not displaying correctly. I notice you have the tabs overview button ⌵ visible. But this is disabled multiple times especially in the vertical tabs file. So either you have a previous theme contradicting the code in this theme. Or something in your browser settings/config is overriding tab related elements in the browser.
    Some useful info may be,

    * any previous themes you might have had

    * any modifications you may have done to the about:config before

    * Firefox edition (default release, dev edition, etc)

    Definitely redownload, and keep me updated if you can.

Hi soulhotel, I just removed all my extensions and themes, deleted my profile folder, uninstalled/reinstalled Firefox ESR 115, and applied the latest version of FF-ULTIMA and I again get the tabs bar along the top. I have not made any changes to about:config

Just switched to regular Firefox v125 instead of ESR and it works perfectly!

@soulhotel
Copy link
Owner

As soon as I saw ESR i had a feeling, if you dont mind could you share a screenshot of how the titlebar looks now?

@DD1TTY
Copy link

DD1TTY commented May 1, 2024

Screenshot 2024-05-01 at 2 13 48 PM

Here is my browser. I added a theme and concealed my bookmarks for privacy. There is still a slight empty space beneath the bookmarks bar, but the vertical tabs are now working as expected.

I added a blank space item to the right of the address bar so I have somewhere I can use to click-and-drag the window around

@soulhotel
Copy link
Owner

Ive managed to get a mac virtual machine running. Mac OS apparently has its own min-height established for toolbars, its such a small one-liner but being able to actually get into Mac has allowed me to fix. This will be slated for 1.7.9 release, probably later today.

2024-06-16_06-16

@soulhotel soulhotel reopened this Jun 16, 2024
@rainlycoris
Copy link
Author

congratulation!
I see that mac in your screenshot don't have sidebars and more, which in the bottom left corner. So the mac can't use these features?
Thank you very much to develop this project!

@soulhotel
Copy link
Owner

soulhotel commented Jun 16, 2024

All the custom preferences are fine, sidebar + autohiding as well.
2024-06-16_06-40

@soulhotel
Copy link
Owner

The next update will have a bit of change that i want users to be aware of. If you want this fix right now, you can simply copy/paste whats in this file below, and put it anywhere, at the bottom of userChrome.css is fine.

https://github.com/soulhotel/FF-ULTIMA/blob/main.update.branch/theme/override-mac.css

@rainlycoris
Copy link
Author

You misunderstand my meaning, I refer to the function of which three icons in the bottom left corner.
截屏2024-06-16 19 01 37

@soulhotel
Copy link
Owner

Works same as everywhere else, drag & drop.

2024-06-16_07-22

@rainlycoris
Copy link
Author

There is no delete icon of tab in the mac full screen, and neither is search box.
截屏2024-06-19 22 29 13
截屏2024-06-19 22 29 26

@soulhotel
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants