Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Depedencies #21

Closed
The-Funk opened this issue Apr 29, 2022 · 3 comments
Closed

Update Depedencies #21

The-Funk opened this issue Apr 29, 2022 · 3 comments

Comments

@The-Funk
Copy link
Contributor

Carl,

I spoke with Per Cederberg the creator of Mibble and asked if they would consider putting Mibble on Maven. Per set up a Maven repo for Mibble on mibble.org which I believe should have a newer version of the library than tnm4j currently. I also did a fork of tnm4j and experimented with updating both Mibble and SNMP4J. Most everything looked to update without issue.

Would you consider updating dependencies? I can submit a PR from my fork if you like but you might wanna double check and test anything I submit.
@ceharris
Copy link
Member

ceharris commented Apr 29, 2022 •
edited
Loading

There's a <repository> element in pom.xml that would need to be changed, and dependency versions would need to be updated too. If you want to do an PR with those changes, I'll merge it.

@The-Funk
Copy link
Contributor Author

The-Funk commented Sep 2, 2022

@ceharris I closed out the previous PR and did a new one that only changes the minor version of SNMP4J and logback. In my testing I didn't notice any failures.

@ceharris
Copy link
Member

Fixed by #23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@The-Funk @ceharris