Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette 1 with CAF-S1 and S4 numbers aren't matching #11

Closed
zkatmich opened this issue Mar 29, 2023 · 6 comments
Closed

Vignette 1 with CAF-S1 and S4 numbers aren't matching #11

zkatmich opened this issue Mar 29, 2023 · 6 comments

Comments

@zkatmich
Copy link

Hello, I was running through the first vignette with the cytokine interaction in CAF-S1 and S4 and noticed my numbers in the figures aren't the same as shown in the vignette figures. It seems mostly to be a scaling issue but the p-value heat map was significantly different. Any feedback or assistance would be greatly appreciated. Thanks in advance.

@lmassenet-regad
Copy link
Collaborator

Hello,
I would be happy to help but I need a bit of context/explanation of what you did and current issues to identify what is happening...

@zkatmich
Copy link
Author

zkatmich commented Mar 31, 2023 via email

@lmassenet-regad
Copy link
Collaborator

lmassenet-regad commented Apr 13, 2023

Hello,
I cannot see what you generated, it is not attached to the previous comment, can you upload the results ?

I think I partially figured out what is happening. This tutorial has been created with an oldest version of the ligand/receptor database, so the plots may not be up-to-date. This may affect the values of global communication scores (as we take into account more interactions) and distributions, although this vignette is restricted to cytokine communication, which did not evolve much in the last version of the database. But the balloon plot values should not be affected.

@zkatmich
Copy link
Author

CAF_barplot.pdf
CAF_heatmap_pvalue.pdf
CAF_network.pdf
CAF_balloonplot.pdf

My apologies, here are the files. Thank you again for your assistance.

@lmassenet-regad
Copy link
Collaborator

Thanks.
I think there is a problem when running the gene.scaling function. In the tutorial:
PC.data=gene.scaling(data = PC.data, n=18, db = transform)
and
CC.data= gene.scaling(data = data, n=4, db = db2)

Normally, after applying this function, the matrix values should be between 0 and 10 for each gene. Maximum values of each interaction is thus 100 in the balloon plot.
Can you check head(PC.data) and head(CC.data) after applying the gene.scaling function ?
Or maybe you have an error message or a warning at this step ?

I hope it helps, let me know!

@zkatmich
Copy link
Author

That helped, the line got commented out somehow where the scaling was applied, the numbers for the balloon plot are matching now. The bar plot and p-value plots still have some slight discrepancies, but not as major as they were before, likely for the reasons you mentioned above. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants