Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LDFLAGS environment variable not preserved #3

Closed
xiota opened this issue Jan 10, 2023 · 3 comments
Closed

LDFLAGS environment variable not preserved #3

xiota opened this issue Jan 10, 2023 · 3 comments

Comments

@xiota
Copy link

xiota commented Jan 10, 2023

Setting LDFLAGS is ignored. The problem is in Makefile:

LDFLAGS = -s

Please change to:

LDFLAGS += -s
@zvezdochiot
Copy link
Member

@xiota say:

Please change to

What for? You can do "it" yourself.

@xiota
Copy link
Author

xiota commented Jan 10, 2023

The purpose of environment variables is so the user can control build parameters without manually editing the build scripts. Changing = to+= preserves the environment variable.

When you say 'do "it" yourself', are you requesting a merge request? Or are you refusing to make any changes to this repository whatsoever?

@zvezdochiot
Copy link
Member

@xiota say:

Or are you refusing to make any changes to this repository whatsoever?

Yes. What for? Everything works. "Keep is simple, stupid".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xiota @zvezdochiot