Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-on:change event not firing. #2

Closed
TAUFEEQ1 opened this issue Jun 28, 2020 · 5 comments
Closed

v-on:change event not firing. #2

TAUFEEQ1 opened this issue Jun 28, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@TAUFEEQ1
Copy link

Hello Thank you for this tool.
change event is not firing.

@soundar24
Copy link
Owner

Hi @TAUFEEQ1, since this acts like a wrapper for roundSlider the events will be treated as props. So the events should be passed like v-bind:change="handler" or :change="handler" instead of v-on. I have updated the same info in the readme also.

Check the below demo and let me know your comments.

https://codesandbox.io/s/vue-round-slider-event-binding-x2emq?file=/src/components/SliderDemo.vue

Thanks..

@TAUFEEQ1
Copy link
Author

@soundar24
Copy link
Owner

@TAUFEEQ1 yes I can find this issue. While click on the slider range, at that time change event was triggered. But when drag the handle and release, at that time change doesn't triggered (seems broken in the recent release).

I will fix this and release in.a couple of days. Good finding, thanks..

@soundar24
Copy link
Owner

@TAUFEEQ1 The change event related issue was resolved, and updated in the below release [v1.0.1]

https://github.com/soundar24/vue-round-slider/releases/tag/v1.0.1

You can simply update to this version and confirm. I have updated in the same demo where change event is working fine.

https://codesandbox.io/s/vue-round-slider-event-binding-x2emq

Please check and let me know if you have any other concerns.. thanks...

@soundar24 soundar24 self-assigned this Jul 3, 2020
@soundar24 soundar24 added the bug Something isn't working label Jul 3, 2020
@TAUFEEQ1
Copy link
Author

TAUFEEQ1 commented Jul 4, 2020

Yes its working, Thank you.

@TAUFEEQ1 TAUFEEQ1 closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants