Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication endpoints timeout causing rate limits to be hit #223

Open
mgoodfellow opened this issue Aug 1, 2022 · 2 comments
Open

Authentication endpoints timeout causing rate limits to be hit #223

mgoodfellow opened this issue Aug 1, 2022 · 2 comments

Comments

@mgoodfellow
Copy link

Hi,

This is a repeat of this issue:

#212

We received a spike in API timeouts for refresh token/obtain token endpoints. When this happens our systems will try to obtain another token. Unfortunately, these timeouts were all counted to our tiny rate limit of 30 calls to /oauth/token endpoint per hour, and has caused our entire site to go offline again.

Having this edge rate limit is far too low when there are disruptions to the API.

There is already a 24 hour limit of 50 tokens granted at a client ID level. This limit makes sense as it actually a token to be issued in other to count to the rate limit. This other rate limit seems to be imposed at the edge, and has no concept of business logic. It triggers even when no tokens are issued.

The levels are so low that we cannot even protect ourselves with circuit breakers as they cannot fire fast enough under load.

Please can this be reviewed.

Specific comment: #212 (comment)

@mgoodfellow
Copy link
Author

@davidjohnson85 stop going through every issue in this repo and posting ChatGPT based responses. This is ridiculous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@mgoodfellow and others