Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure package.json version gets updated on release #51

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

lukehorvat
Copy link
Contributor

The version in package.json has been stuck on 3.0.1 for a while and is not in sync with the version in the npm registry. It doesn't really matter, but I thought I'd fix anyway.

It seems we need to swap the order of the semantic-release plugins, npm and git. See: semantic-release/semantic-release#1593 (comment)

Copy link
Contributor

@bruderstein bruderstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks Luke!

@bruderstein
Copy link
Contributor

BTW, i can't merge this any more :(

Copy link
Contributor

@pablofmena pablofmena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@pablofmena
Copy link
Contributor

@bruderstein long time no see! thanks for being on top of things always ❤️ I hope all is well on the other side 🙂

@lukehorvat
Copy link
Contributor Author

thanks dave, hope you are doing well!

@lukehorvat lukehorvat merged commit 6cf1f96 into master Feb 17, 2023
@lukehorvat lukehorvat deleted the ensure-update-package-version branch February 17, 2023 11:08
@intervene-ci
Copy link
Collaborator

🎉 This PR is included in version 3.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

intervene-ci pushed a commit that referenced this pull request Feb 17, 2023
## [3.1.4](v3.1.3...v3.1.4) (2023-02-17)

### Bug Fixes

* Use semantic-release plugin defaults so that fix from [#51](#51) works ([8bd5b77](8bd5b77))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants